Skip to content

Log in with SPN and password as String is possible #164 #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NowinskiK merged 4 commits into from
Dec 13, 2025
Merged

Log in with SPN and password as String is possible #164 #178

NowinskiK merged 4 commits into from
Dec 13, 2025

Conversation

@NowinskiK
Copy link
Contributor

@NowinskiK NowinskiK commented Dec 13, 2025 •
edited
Loading

Pull Request

Fixed

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency -Tasks build, test).
  • Comment-based help added/updated.
  • Examples appropriately added/updated.
  • Unit tests added/updated..
  • Integration tests added/updated (where possible).
  • Documentation added/updated (where applicable).
  • Code follows the contribution guidelines.

@NowinskiK NowinskiK marked this pull request as draft December 13, 2025 15:47
@github-actions
Copy link

github-actions bot commented Dec 13, 2025 •
edited
Loading

Linux Test Results

5 133 tests   5 132 ✅  44s ⏱️
  623 suites      1 💤
    1 files        0 ❌

Results for commit a68af49.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 13, 2025 •
edited
Loading

WinPS51 Test Results

5 347 tests   5 346 ✅  1m 7s ⏱️
  624 suites      1 💤
    1 files        0 ❌

Results for commit a68af49.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 13, 2025 •
edited
Loading

WinPS71 Test Results

5 347 tests   5 346 ✅  1m 3s ⏱️
  624 suites      1 💤
    1 files        0 ❌

Results for commit a68af49.

♻️ This comment has been updated with latest results.

@NowinskiK NowinskiK marked this pull request as ready for review December 13, 2025 16:45
tiagobalabuch
tiagobalabuch approved these changes Dec 13, 2025
View reviewed changes
Copy link
Contributor

@tiagobalabuch tiagobalabuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@NowinskiK NowinskiK merged commit 7fb9176 into develop Dec 13, 2025
8 checks passed
@NowinskiK NowinskiK deleted the bug_164_spn branch December 13, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiagobalabuch tiagobalabuch tiagobalabuch approved these changes

@Frank-Geisler Frank-Geisler Awaiting requested review from Frank-Geisler

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logging in with a Service Principal does not work

3 participants

@NowinskiK @tiagobalabuch